Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version labeling of container #59

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Fix version labeling of container #59

merged 1 commit into from
Jun 24, 2024

Conversation

berrydenhartog
Copy link
Member

@berrydenhartog berrydenhartog commented Jun 24, 2024 •
edited
Loading

Description

Currenlty the version is replaced with an empty string because it can not see the full git history.

The following command fails

git describe --tags

maybe fetch-tags: '' is also sufficient.

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

anneschuth
anneschuth approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@anneschuth anneschuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berrydenhartog berrydenhartog merged commit f6c3f09 into main Jun 24, 2024
14 checks passed
@berrydenhartog berrydenhartog deleted the fix-version-labeling-main branch June 24, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anneschuth anneschuth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berrydenhartog @anneschuth