Add first version of C4 architecture diagrams #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to our community 🤗 and thank you for your first contribution.
As a first time contributor please make sure to review our contribution guidelines ❤️
GuusjeJuijn
changed the title
DescriptionCreates a `docs/architecture/ folder containing:
Resolves: https://github.com/orgs/MinBZK/projects/7/views/3?pane=issue&itemId=59900118 ChecklistPlease check all the boxes that apply to this pull request using "x":
|
|
First very minor remark, could you |
laurensWe
reviewed
Jun 5, 2024
laurensWe
reviewed
Jun 5, 2024
GuusjeJuijn
force-pushed
the
add-architecture-diagrams
branch
from
7256894 to
b68d3c8
Compare
laurensWe
reviewed
Jun 5, 2024
GuusjeJuijn
force-pushed
the
add-architecture-diagrams
branch
from
71c563e to
1bc9b4d
Compare
laurensWe
force-pushed
the
add-architecture-diagrams
branch
from
1bc9b4d to
10bfe55
Compare
Co-authored-by: Laurens Weijs <laurensweijs@gmail.com> Signed-off-by: GuusjeJuijn <96429015+GuusjeJuijn@users.noreply.github.com>
laurensWe
force-pushed
the
add-architecture-diagrams
branch
from
10bfe55 to
b753995
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a `docs/architecture/ folder containing:
architecture.md: a Markdown document containing C4-style diagrams for the Algorithm Management Toolkit. This document contains a system diagram, a container diagram and a component diagram, and a walkthrough and example text explaining the diagrams.Resolves: https://github.com/orgs/MinBZK/projects/7/views/3?pane=issue&itemId=59900118
Checklist
Please check all the boxes that apply to this pull request using "x":