Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

152 add pre commit check for translations #217

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

ChristopherSpelt
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt commented Sep 27, 2024

Description

Script to check if the translate update and compile are executed. Intended use is a pre-commit hook; it will check if staged .po files are up to date, if not it will show a message "Translations are not up to date." and the pre commit hook will fail. Note that the script runs the translate update and compile commands, so the script is idempotent. Running the pre commit hook twice on staged .po files will make the pre-commit hook pass.

Out of scope:

  • check if all translation strings are present.

Resolves #152

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@ChristopherSpelt ChristopherSpelt linked an issue Sep 27, 2024 that may be closed by this pull request
@ChristopherSpelt ChristopherSpelt force-pushed the 152-add-pre-commit-check-for-translations branch 2 times, most recently from abcd559 to 8d19de7 Compare September 27, 2024 10:18
anneschuth
anneschuth previously approved these changes Sep 27, 2024
Copy link
Member

@anneschuth anneschuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

berrydenhartog
berrydenhartog previously approved these changes Oct 1, 2024
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

berrydenhartog
berrydenhartog previously approved these changes Oct 4, 2024
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@anneschuth anneschuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

sonarqubecloud bot commented Oct 4, 2024

@ChristopherSpelt ChristopherSpelt marked this pull request as ready for review October 4, 2024 09:14
@ChristopherSpelt ChristopherSpelt requested a review from a team as a code owner October 4, 2024 09:14
@ChristopherSpelt ChristopherSpelt merged commit 29842ab into main Oct 4, 2024
16 checks passed
@ChristopherSpelt ChristopherSpelt deleted the 152-add-pre-commit-check-for-translations branch October 4, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pre-commit check for translations
3 participants