Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

100 navigation bar #191

Merged
merged 1 commit into from
Sep 18, 2024
Merged

100 navigation bar #191

merged 1 commit into from
Sep 18, 2024

Conversation

uittenbroekrobbert
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert commented Sep 9, 2024 •
edited
Loading

Description

Adds the main and submenu and breadcrumbs to various pages. Also includes some restructure in the templates folder and changes in the webpack.

Most significant changes:

  • main menu, submenu and breadcrumbs, for mobile and desktop
  • removed old CSS solutions to use ROOS where possible, tasks page has been updated
  • fixed icons in ROOS with a hardcoded rewrite solution (in webpack)

Resolves #100

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@uittenbroekrobbert uittenbroekrobbert linked an issue Sep 9, 2024 that may be closed by this pull request
Navigation bar #100
Closed
@uittenbroekrobbert uittenbroekrobbert force-pushed the 100-navigation-bar branch 2 times, most recently from ceeebdb to 78477b8 Compare September 16, 2024 12:21
@anneschuth anneschuth marked this pull request as ready for review September 16, 2024 14:00
@anneschuth anneschuth requested a review from a team as a code owner September 16, 2024 14:00
anneschuth
anneschuth reviewed Sep 16, 2024
View reviewed changes
@uittenbroekrobbert uittenbroekrobbert force-pushed the 100-navigation-bar branch 6 times, most recently from a3eefa0 to 76bf223 Compare September 18, 2024 09:49
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ChristopherSpelt
ChristopherSpelt approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@uittenbroekrobbert uittenbroekrobbert merged commit 6b33e93 into main Sep 18, 2024
16 checks passed
@uittenbroekrobbert uittenbroekrobbert deleted the 100-navigation-bar branch September 18, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anneschuth anneschuth anneschuth left review comments

@ChristopherSpelt ChristopherSpelt ChristopherSpelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navigation bar
3 participants
@uittenbroekrobbert @anneschuth @ChristopherSpelt