Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for sqlite alter table limitation #106

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

berrydenhartog
Copy link
Member

@berrydenhartog berrydenhartog commented Jul 19, 2024

Description

SQLite does not support the alter-table command. Only though the batch.

We often do not want to edit migrations but made an exception in this case since the migration does the same thing but in a different way. tested the migration in both sqlite and postgress and it works.

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
berrydenhartog Berry den Hartog
@berrydenhartog berrydenhartog requested a review from a team as a code owner July 19, 2024 10:19
Copy link

@ChristopherSpelt ChristopherSpelt merged commit aa4692f into main Jul 19, 2024
14 checks passed
@ChristopherSpelt ChristopherSpelt deleted the fix-migrations-sqlite-alter-table branch July 19, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants