Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Make active unit's tab name green #1577

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

huchenlei
Copy link
Collaborator

When the user has a lot of controlnet units enabled. It can be hard to figure out what unit is enabled, what unit is not. Users have to check each unit tab and see if enable is checked.

This PR adds the feature that makes active unit's tab name green so that users can easily know which unit is enabled.

Effect with light theme:
Screen Capture 006 - Stable Diffusion - 127 0 0 1

Effect with dark theme:
Screen Capture 007 - Stable Diffusion - 127 0 0 1

Gradio recreate tab nav buttons every time active tab switches, which makes this feature implementation very hacky, but I am satisfied with the result.

@huchenlei
Copy link
Collaborator Author

Now use brighter green in dark mode to assist reading:
Screen Capture 008 - Stable Diffusion - 127 0 0 1

@huchenlei huchenlei merged commit 1f66e9c into Mikubill:main Jun 7, 2023
lllyasviel added a commit that referenced this pull request Jun 7, 2023
* 🐛 Disable logging propagate (#1555)

* 🎨 colorize loglevel (#1556)

* 🎨 Fix bg color under dark theme in modal (#1557)

* fix api (#1565)

* Added support for control mode to xyz grid (#1550)

Control mode was inexplicably missing from xyz grid. I've added it.

* fix bugs in 218 (#1576)

* 🎨 Make active unit's tab name green (#1577)

* 🎨 Make active unit's tab name green

* 🎨 Use brighter green in dark mode

* 🎨 Add active units count badge (#1578)

---------

Co-authored-by: Chenlei Hu <chenlei.hu@mail.utoronto.ca>
Co-authored-by: Ezekiel-Rage <37027067+Ezekiel-Rage@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant