Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If scan the DOM on ready #87

Closed
GermanBluefox opened this issue Nov 20, 2016 · 2 comments
Closed

If scan the DOM on ready #87

GermanBluefox opened this issue Nov 20, 2016 · 2 comments
Assignees
@Mikhus
Labels
enhancement
Milestone
2.1.0

Comments

@GermanBluefox
Copy link

GermanBluefox commented Nov 20, 2016 •
edited
Loading

My editor has over 5000 elements on the page. And canvas-gauges scan at DOMready all these elements.

It would be very useful to make this feature controllable and create gauges only dynamically.
5000 take about 1.5 seconds to be "checked".

Just now I disabled this line:
https://github.com/Mikhus/canvas-gauges/blob/master/lib/DomObserver.js#L112
And everything is fast again.
@Mikhus
Copy link
Owner

Mikhus commented Dec 1, 2016

I could propose to have some global flag to prevent auto DOM check. Will add this in 2.1

Mikhus added a commit that referenced this issue Dec 1, 2016
@Mikhus
Implemented issue #87 - added possibility to control automatic DOM do…
2b44193 
…cument parsing to create gauges
@Mikhus Mikhus added this to the 2.1.0 milestone Dec 1, 2016
@Mikhus Mikhus self-assigned this Dec 1, 2016
@Mikhus
Copy link
Owner

Mikhus commented Dec 1, 2016

Implemented in 2.1 branch

@Mikhus Mikhus closed this as completed Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mikhus Mikhus

Labels
enhancement
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@Mikhus @GermanBluefox