Migrate pyslang into this repository #1210
Conversation
parker-research
force-pushed
the
migrate-pyslang
branch
from
df50313 to
9601c22
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1210 +/- ##
=======================================
Coverage 94.67% 94.67%
=======================================
Files 204 204
Lines 51166 51166
=======================================
Hits 48439 48439
Misses 2727 2727 Continue to review full report in Codecov by Sentry.
|
| merge-multiple: true | ||
| - uses: pypa/gh-action-pypi-publish@release/v1 | ||
| with: | ||
| password: ${{ secrets.TEST_PYPI_API_TOKEN }} |
There was a problem hiding this comment.
Note to self: setup this secret in this repo before landing.
| @@ -1,10 +1,17 @@ | |||
| .vs/ | |||
There was a problem hiding this comment.
I don't think .vs or .vscode should be unignored -- you can just exempt the one settings.json file like:
!.vscode/settings.json
pyslang/LICENSE
Outdated
| @@ -0,0 +1,19 @@ | |||
| Copyright (c) 2023-2024 Michael Popoloski | |||
There was a problem hiding this comment.
Probably don't need this as a separate file, the parent directory has the same license.
|
Thanks a lot for checking that over; solid comments! Just pushed those changes now! |
Related to the discussion over in https://github.com/MikePopoloski/pyslang/issues/379, this PR moves the
pyslangproject into this repo, updates the Pythonpyproject.tomlscript a bit.It also adds the type stubs work from over in https://github.com/MikePopoloski/pyslang/issues/382. I can back out this change if you'd like, though.