Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor query builder api *breaking change* #60

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

cylkdev
Copy link
Contributor

@cylkdev cylkdev commented Sep 21, 2024

The current implementation of the EctoShorts.QueryBuilder api is written in a way that is specific to the internal function calls of the api. This change makes the callback function create_schema_filter a 3-arity function and re-arranges the order of the arguments so that the query is the first argument which allows these functions to be chained together.

@cylkdev
Copy link
Contributor Author

cylkdev commented Sep 21, 2024

@MikaAK My current understanding is that there is no expectation that this was to be used prior to this and therefore it was not documented. This change will allow us to better support #47 and we can add it to the documentation.

Copy link
Contributor

@BobbieBarker BobbieBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MikaAK MikaAK merged commit 9653ea7 into MikaAK:main Oct 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants