Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Swift6 and async/await #48

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

gennaro-safehill
Copy link
Contributor

No description provided.

@MihaelIsaev
Copy link
Owner

Hey @gennaro-safehill, thanks for the great pull request! It looks good. Is it ready to be merged?

@gennaro-safehill
Copy link
Contributor Author

Hey @gennaro-safehill, thanks for the great pull request! It looks good. Is it ready to be merged?

You're welcome! I'm an open-sourcer and it's all about helping the community!
I'm testing the code out right now, I'll let you know

@MihaelIsaev
Copy link
Owner

Thank you @gennaro-safehill, once you confirm it works well I'm ready to merge and tag it as v3.0.0

@gennaro-safehill
Copy link
Contributor Author

I run into some problems deploying this code to Heroku using Swift 6.
There are some problems with the buildpack.

Using Swift 5.10 works. There are no code changes, it's only about the swift-tools-version in Package.swift.
Testing the changes right now in staging.

@@ -14,7 +14,7 @@ let package = Package(
dependencies: [
// 💧 A server-side Swift web framework.
.package(url: "https://github.com/vapor/vapor.git", from: "4.0.0"),
.package(url: "https://github.com/vapor/jwt.git", from: "4.0.0"),
.package(url: "https://github.com/vapor/jwt.git", exact: "5.0.0-rc.1"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.package(url: "https://github.com/vapor/jwt.git", exact: "5.0.0-rc.1"),
.package(url: "https://github.com/vapor/jwt.git", from: "5.0.0"),

JWT v5 is now released.

@gennaro-safehill
Copy link
Contributor Author

Hi folks. Just wanted to let you know that I wasn't able to test these changes in my production environment with Swift 6 because we use Heroku and the buildpack for Swift 6 has some compat issues.

I did test them with 5.10, and they work great!
We have 2 options:

  1. Merge this code as is
  2. Merge the 5.10 version at Support for Swift 5.10 #49 (there's only one line change on top of the changes proposed here setting the swift-tools-version to 5.10.0

Let me know what you prefer

@ptoffy
Copy link
Contributor

ptoffy commented Nov 7, 2024

Hey, would love to update to JWTKit 5 too and therefore relying on this. Are there any blockers?

@gennaro-safehill
Copy link
Contributor Author

No blockers. See my message above

@MihaelIsaev
Copy link
Owner

@gennaro-safehill I think this will work great! I'm ready to merge and tag it as v3 once the README is updated. Could you please update the README as well?

@MihaelIsaev MihaelIsaev merged commit c166e4b into MihaelIsaev:master Nov 8, 2024
@MihaelIsaev MihaelIsaev mentioned this pull request Nov 8, 2024
@MihaelIsaev
Copy link
Owner

@gennaro-safehill Many thanks for your contribution! It is now available since 3.0.0-beta.1 tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants