-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Swift6 and async/await #48
Conversation
Hey @gennaro-safehill, thanks for the great pull request! It looks good. Is it ready to be merged? |
You're welcome! I'm an open-sourcer and it's all about helping the community! |
Thank you @gennaro-safehill, once you confirm it works well I'm ready to merge and tag it as |
I run into some problems deploying this code to Heroku using Swift 6. Using Swift 5.10 works. There are no code changes, it's only about the |
@@ -14,7 +14,7 @@ let package = Package( | |||
dependencies: [ | |||
// 💧 A server-side Swift web framework. | |||
.package(url: "https://github.com/vapor/vapor.git", from: "4.0.0"), | |||
.package(url: "https://github.com/vapor/jwt.git", from: "4.0.0"), | |||
.package(url: "https://github.com/vapor/jwt.git", exact: "5.0.0-rc.1"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.package(url: "https://github.com/vapor/jwt.git", exact: "5.0.0-rc.1"), | |
.package(url: "https://github.com/vapor/jwt.git", from: "5.0.0"), |
JWT v5 is now released.
Hi folks. Just wanted to let you know that I wasn't able to test these changes in my production environment with Swift 6 because we use Heroku and the buildpack for Swift 6 has some compat issues. I did test them with 5.10, and they work great!
Let me know what you prefer |
Hey, would love to update to JWTKit 5 too and therefore relying on this. Are there any blockers? |
No blockers. See my message above |
@gennaro-safehill I think this will work great! I'm ready to merge and tag it as v3 once the README is updated. Could you please update the README as well? |
@gennaro-safehill Many thanks for your contribution! It is now available since |
No description provided.