Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sendMessage to the FCMProvider protocol so it can be mocked in tests #13

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

FredericRuaudel
Copy link
Contributor

Hello !

This PR declare the sendMessage in the FCMProvider protocol so we can mock it by using the config.prefer mechanism of Vapor 3 like this:

services.register(FCMMock.self)
config.prefer(FCMMock.self, for: FCMProvider.self)

@m-maillot
Copy link

I vote for this PR :)

@MihaelIsaev MihaelIsaev merged commit f3a4b8a into MihaelIsaev:master Nov 27, 2019
@FredericRuaudel
Copy link
Contributor Author

Thanks for the quick merge! 🙏

@MihaelIsaev
Copy link
Owner

@FredericRuaudel you're welcome! Thanks for the useful pull request! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants