Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2 altogether #796

Closed
6 tasks done
s-martin opened this issue Feb 20, 2020 · 6 comments
Closed
6 tasks done

Drop Python 2 altogether #796

s-martin opened this issue Feb 20, 2020 · 6 comments
Milestone

Comments

@s-martin
Copy link
Collaborator

s-martin commented Feb 20, 2020

Some code was still Python 2 and some dependencies already dropped Python 2 support, which was causing issues, e.g. #783, #784.

To address this Python 2 should be removed altogether.

On develop this has already been done for many parts of the code base. Currently Python2 packages are still installed.

For master a PR #795 was also opened.
For remaining tasks on develop PR #801 was opened.

This ticket should collect all necessary tasks left.

@ZyanKLee ZyanKLee added this to the 2.0 milestone Feb 20, 2020
@s-martin
Copy link
Collaborator Author

Maybe we should keep the installation scripts for stretch as it is.

For buster the mopidy3 script could be merged to default.sh first

@s-martin
Copy link
Collaborator Author

There seems to be an issue with mopidy-iris 3.43, which we currently have to use, because it’s the last python 2 version. See #759.

So we should fix this better sooner than later.

@s-martin
Copy link
Collaborator Author

I think it may be better to not change anything on stretch, existing installations probably work and for new installations buster should be used anyway.

@s-martin
Copy link
Collaborator Author

s-martin commented Mar 8, 2020

On master some parts where missing, see #842.

Maybe #822 needs to be merged to master.

Issue is master still needs Mopidy stuff to be python2, but our code is now python 3. Right now the install script on master just install python 2.7 packages.

@s-martin
Copy link
Collaborator Author

s-martin commented Mar 8, 2020

On master some parts where missing, see #842.

Maybe #822 needs to be merged to master.

Issue is master still needs Mopidy stuff to be python2, but our code is now python 3. Right now the install script on master just install python 2.7 packages.

Fixed this with #843

@s-martin
Copy link
Collaborator Author

s-martin commented Mar 8, 2020

All Python 2 dependencies have been removed from buster on develop.

@s-martin s-martin closed this as completed Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants