Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem/Bug]: Transient Dependencies broken in 1.0.2651.64 #4749

Closed
RickStrahl opened this issue Aug 17, 2024 · 1 comment
Closed

[Problem/Bug]: Transient Dependencies broken in 1.0.2651.64 #4749

RickStrahl opened this issue Aug 17, 2024 · 1 comment
Assignees
Labels
bug Something isn't working regression Something used to work but doesn't anymore

Comments

@RickStrahl
Copy link

RickStrahl commented Aug 17, 2024

What happened?

I'm seeing a bunch of broken dependencies in existings projects that appear to be caused by transient dependencies not being forwarded properly.

Scenario:

  • I have a base class in a library project
  • Project is a class library that references Microsoft.WebView2.Wpf
    (provides wrapper services around the WebView as a behavior essentially)
  • I then have a top level application project that references my library but not Microsoft.WebView2.Wpf

This has always worked thus far without requiring an explicit reference to the WebView2.WPF library in the top level application project - ie. the Westwind.WebView package in the past provided the transient dependency to the WebVIew. This worked fine up until 1.0.2592.51.

After installing 1.0.2651.64 I now get errors for any explicit references to WebView components:

image

Microsoft.Web.WebView2.Core or any other type that lives in the Microsoft.WebView.WPF package is not resolving unless I explicitly add the package Microsoft.WebView2.Wpf package.

I can alleviate this only by explicitly installing the Microsoft.WebView2.Wpf package to the top level project. The problem with this is that it now becomes a lot more complex to keep versions in sync.

This should not be necessary - why wouldn't the transient references work and why did this start failing in 1.0.2651.64?

64 bit • .NET 8.0.8
Microsoft Windows 10.0.22631
WebView Runtime: 127.0.2651.105
WebView Sdk: 1.0.2592.51

Tried:

  • Clean full rebuild
  • Unload/reload project
  • Cleaning out .vs solution folder (just to be sure)

More Detail on Project

This fails

image

This works

image

Using old version 1.0.2592.51 in Westwind.WebView works

image

You can try this out with this repo:

https://github.com/RickStrahl/Westwind.WebView

Importance

Blocking. My app's basic functions are not working due to this issue.

Runtime Channel

Stable release (WebView2 Runtime)

Runtime Version

127.0.2651.105

SDK Version

1.0.2592.51

Framework

WPF

Operating System

Windows 11

OS Version

10.0.22631

Repro steps

see above

Repros in Edge Browser

No, issue does not reproduce in the corresponding Edge version

Regression

Regression in newer Runtime

Last working version (if regression)

1.0.2592.51

@RickStrahl RickStrahl added the bug Something isn't working label Aug 17, 2024
@github-actions github-actions bot added the regression Something used to work but doesn't anymore label Aug 17, 2024
RickStrahl added a commit to RickStrahl/Westwind.WebView that referenced this issue Aug 18, 2024
@vbryh-msft
Copy link
Contributor

vbryh-msft commented Aug 19, 2024

is it the same issue - #4743 ? Edited: confirmed that it is dupe - we are working on the fix, please follow that thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Something used to work but doesn't anymore
Projects
None yet
Development

No branches or pull requests

3 participants