Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rowsToScroll from the global settings section #87

Merged
merged 3 commits into from
Jul 20, 2020

Conversation

DHowett
Copy link
Contributor

@DHowett DHowett commented Jul 14, 2020

@DHowett
Copy link
Contributor Author

DHowett commented Jul 14, 2020

@cinnamon-msft how do we handle the removal of settings? This one is very much "I'm just dropping it from the docs", but maybe we need to add an "Until 1.2" badge?

@opbld31
Copy link

opbld31 commented Jul 14, 2020

Docs Build status updates of commit cbb3881:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/customize-settings/global-settings.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@cinnamon-msft
Copy link
Collaborator

Maybe "Deprecated in 1.2" and leave it for a bit?

@opbld31
Copy link

opbld31 commented Jul 14, 2020

Docs Build status updates of commit 4f70e13:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/customize-settings/global-settings.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld32
Copy link

opbld32 commented Jul 14, 2020

Docs Build status updates of commit 7d93e6a:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/customize-settings/global-settings.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@cinnamon-msft cinnamon-msft merged commit 4b42125 into release-1.2 Jul 20, 2020
@carlos-zamora carlos-zamora deleted the DHowett-patch-1 branch June 24, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants