Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into live #555

Merged
merged 59 commits into from
Jul 6, 2022
Merged

Merge main into live #555

merged 59 commits into from
Jul 6, 2022

Conversation

cinnamon-msft
Copy link
Collaborator

No description provided.

shgogna and others added 30 commits December 13, 2021 09:40
* Update dynamic-profiles.md

Create section for dynamic profile for `Developer Powershell for VS 2019`

* Update dynamic-profiles.md

Update name and remove `startingDirectory`

* Update dynamic-profiles.md

Explain a little better
* Update new-tab-same-directory.md

* Update new-tab-same-directory.md
..these are now officially dynamic profiles.. so no longer need to be added as 3rd party as of Terminal v. 1.12. :)
"it's" should be "its" because it wouldn't make sense otherwise.
Add information on GUID generation based on microsoft/terminal#10374
and improve wording to make the importance of a profile GUID clearer.
Resolves #483
Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
Co-authored-by: Mike Griese <migrie@microsoft.com>
mattwojo and others added 26 commits February 8, 2022 13:42
* troubleshooting: Linux paths support in 'startingDirectory' was added in 1.11.2921.0

In 7cd48bc (startingDirectory path for WSL no longer requires prefix,
2022-01-07), the "Set your WSL distribution to start in the home
directory" section of the troubleshooting guide was updated to mention
that WSL paths can now be directly referenced, following
microsoft/terminal@a2a6050 (When launching wsl, promote the starting
directory to --cd (#9223), 2021-08-02).

The text mentions this feature was added in Windows Terminal
1.12.3472.0, but it actually dates back to v1.11.2421.0 (Preview) and
v1.11.2921.0 (Stable).

Update the text to mention the stable version, and link to this version
in the GitHub releases. Also slightly improve the wording (s/are now/can
now be/).

* troubleshooting: remove confusing 'Important' note about WSL 'startingDirectory'

In e7f739e (Docs updates for 1.11 release (#397), 2021-08-31), an
"Important" note was added to the "Set your WSL distribution to start in
the home directory" section of the troubleshooting page to mention that
'startingDirectory' now accepts Linux-style paths, following
microsoft/terminal@a2a6050 (When launching wsl, promote the starting
directory to --cd (#9223), 2021-08-02).

The note mentions that Linux-styled paths were accepted "on newer
versions of Windows", presumably meaning newer than 1903. Indeed, that
version was at the time mentioned in the text as the first Windows
vesion supporting the '//wsl$/' P9 prefix (it had been mentioned since
the WSL startingDirectory troubleshooting entry was created in da815cc
(Review troubleshooting page, 2020-05-04).

The text of the section was updated in 7cd48bc (startingDirectory path
for WSL no longer requires prefix, 2022-01-07) to add an example with a
Linux-style path, and to mention that this feature was added in Windows
Terminal itself (not in Windows), thus removing the mention of Windows
1903. However, the "Important" note was left, and it still confusingly
mentions that Linux-style paths are accepted on "newer" versions of
Windows, without mentioning newer than what.

Remove the note altogether.

* .gitattributes: mark '*.md' as Markdown files

Denote Markdown files as such with the 'diff' Git attribute [1]. This
allows various Git commands (diff [2, 3], grep [4, 5], log [6], blame
[7]) to show in which part of the "code" the changes are located in the
hunk header, i.e. the previous commit would be shown as

    diff --git a/TerminalDocs/troubleshooting.md
    b/TerminalDocs/troubleshooting.md
    index 4a880fa..2c9d14d 100644
    --- a/TerminalDocs/troubleshooting.md
    +++ b/TerminalDocs/troubleshooting.md
    @@ -40,8 +40,6 @@ ## Set your WSL distribution to start in the home `~` directory when launched
     }
     ```

    -> [!IMPORTANT]
    -> On newer versions of Windows, `startingDirectory` can accept Linux-style paths.

     ## Setting the tab title

Notice how the hunk header indicates the changes are in the "Set your
WSL distribution to start in the home" section.

The history of that specific entry can now be interrogated using

    git log -L:"Set your WSL distribution":TerminalDocs/troubleshooting.md

[1] https://git-scm.com/docs/gitattributes#_defining_a_custom_hunk_header
[2] https://git-scm.com/docs/git-diff#_generating_patch_text_with_p
[3] https://git-scm.com/docs/git-diff#Documentation/git-diff.txt--W
[4] https://git-scm.com/docs/git-grep#Documentation/git-grep.txt--p
[5] https://git-scm.com/docs/git-grep#Documentation/git-grep.txt--W
[6] https://git-scm.com/docs/git-log#Documentation/git-log.txt--Lltfuncnamegtltfilegt
[7] https://git-scm.com/docs/git-blame#Documentation/git-blame.txt--Lltfuncnamegt
* Add acrylic issues to troubleshooting doc

* Add autohide cursor setting

* Add windows settings differentiator
Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
* Document keyboard selection (#552)

* minor tweaks

* Document scroll marks

* Fix warning

* Remove old preview labels

Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
@opbld32
Copy link

opbld32 commented Jul 6, 2022

Docs Build status updates of commit 4187581:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/customize-settings/actions.md ✅Succeeded View
TerminalDocs/customize-settings/appearance.md ✅Succeeded View
TerminalDocs/customize-settings/profile-advanced.md ✅Succeeded View
TerminalDocs/images/oh-my-posh-winget.png ✅Succeeded View
TerminalDocs/install.md ✅Succeeded View
TerminalDocs/selection.md ✅Succeeded View
TerminalDocs/tutorials/custom-prompt-setup.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld31
Copy link

opbld31 commented Jul 6, 2022

Docs Build status updates of commit d83b79a:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/customize-settings/actions.md ✅Succeeded View
TerminalDocs/customize-settings/appearance.md ✅Succeeded View
TerminalDocs/customize-settings/profile-advanced.md ✅Succeeded View
TerminalDocs/images/oh-my-posh-winget.png ✅Succeeded View
TerminalDocs/install.md ✅Succeeded View
TerminalDocs/selection.md ✅Succeeded View
TerminalDocs/TOC.yml ✅Succeeded View
TerminalDocs/tutorials/custom-prompt-setup.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@cinnamon-msft cinnamon-msft merged commit a8539cf into live Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.