Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document useBackgroundImageForWindow #540

Merged
merged 1 commit into from
May 23, 2022

Conversation

carlos-zamora
Copy link
Contributor

Document experimental.useBackgroundImageForWindow from microsoft/terminal#12893

@opbld33
Copy link

opbld33 commented May 16, 2022

Docs Build status updates of commit b0cbe1b:

⚠️ Validation status: warnings

File Status Preview URL Details
TerminalDocs/customize-settings/appearance.md ⚠️Warning View Details

TerminalDocs/customize-settings/appearance.md

  • Line 242, Column 1: [Warning: file-not-found - See documentation] Invalid file link: './../images/background-image-for-window.png'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@carlos-zamora
Copy link
Contributor Author

@cinnamon-msft two things here...

  1. be sure to add the image. It doesn't actually exist. Figured you'd want to get an image/gif for the blog so might as well just throw it in here
  2. idk if there's a way to denote experimental settings? It didn't seem like it from the other ones, but figured I'd mention it just in case.

@cinnamon-msft cinnamon-msft changed the base branch from main to release-1.14 May 23, 2022 00:15
@opbld33
Copy link

opbld33 commented May 23, 2022

Docs Build status updates of commit b0cbe1b:

⚠️ Validation status: warnings

File Status Preview URL Details
TerminalDocs/customize-settings/appearance.md ⚠️Warning View Details

TerminalDocs/customize-settings/appearance.md

  • Line 242, Column 1: [Warning: file-not-found - See documentation] Invalid file link: './../images/background-image-for-window.png'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@cinnamon-msft cinnamon-msft merged commit 783f7b6 into release-1.14 May 23, 2022
@cinnamon-msft cinnamon-msft deleted the dev/cazamor/useBackgroundImageForWindow branch May 23, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants