Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit state that windows key is not supported #120

Merged
merged 2 commits into from
Sep 10, 2020

Conversation

wulfland
Copy link
Contributor

The documentation is not clear that the Windows key is not a valid modifier for key bindings. I think people are looking for this when they try to customize their terminal - at least I did and it took me a lot of effort to find that this is not ab option yet.

The corresponding Issue for the feature request is #3184

Documentation is not clear that the `Windows` key is not a valid modifier. I think people are looking for this when they try to customize their terminal.
@opbld31
Copy link

opbld31 commented Aug 24, 2020

Docs Build status updates of commit 7ad5523:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/customize-settings/key-bindings.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link

opbld30 commented Sep 10, 2020

Docs Build status updates of commit 168c950:

⚠️ Validation status: warnings

File Status Preview URL Details
TerminalDocs/customize-settings/key-bindings.md ⚠️Warning View Details

TerminalDocs/customize-settings/key-bindings.md

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@cinnamon-msft cinnamon-msft merged commit 2128706 into MicrosoftDocs:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants