Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

PR builds on Node 6 fail during linting #684

Closed
JoshuaKGoldberg opened this issue Dec 18, 2018 · 1 comment · Fixed by #686
Closed

PR builds on Node 6 fail during linting #684

JoshuaKGoldberg opened this issue Dec 18, 2018 · 1 comment · Fixed by #686
Labels
Domain: Tooling Repository tasks around improving source tooling. Type: Bug
Milestone

Comments

@JoshuaKGoldberg
Copy link

Example PR: #682
Example build break: https://travis-ci.org/Microsoft/tslint-microsoft-contrib/jobs/469577861

/home/travis/build/Microsoft/tslint-microsoft-contrib/src/noUnnecessaryOverrideRule.ts:63:51
ERROR: 63:51   increment-decrement  Use an explicit += 1 operator.
/home/travis/build/Microsoft/tslint-microsoft-contrib/src/utils/BaseFormatter.ts:21:62
ERROR: 21:62   increment-decrement  Use an explicit -= 1 operator.
/home/travis/build/Microsoft/tslint-microsoft-contrib/src/utils/Utils.ts:13:46
ERROR: 13:46   increment-decrement  Use an explicit += 1 operator.
/home/travis/build/Microsoft/tslint-microsoft-contrib/src/validTypeofRule.ts:97:40
ERROR: 97:40   increment-decrement  Use an explicit += 1 operator.
ERROR: 102:40  increment-decrement  Use an explicit += 1 operator.
ERROR: 107:40  increment-decrement  Use an explicit += 1 operator.
ERROR: 108:44  increment-decrement  Use an explicit += 1 operator.
@JoshuaKGoldberg JoshuaKGoldberg added Type: Bug Domain: Tooling Repository tasks around improving source tooling. labels Dec 18, 2018
@JoshuaKGoldberg
Copy link
Author

increment-decrement was added in the just-released TSLint 5.12.0. It's spooky and mysterious that Node 6 isn't respecting package-lock.json. This should be fixed by updating the dependency version.

JoshuaKGoldberg pushed a commit that referenced this issue Dec 27, 2018
…cy to 5.12.0) (#686)

* Deprecated now-duplicate rules from TSLint 5.12.0 (bumped devDependency to 5.12.0)

Fixes #684. Fixes #685.

* Added missing deprecation notices in README.md

* Update noUnnecessaryBindRule.ts

* Corrected changes in package-lock.json and metadata

* Fixed recommended ruleset and tslint warnings

* Removed breaking rule changes

* Fixed recommendation typos

* Updated metadata files

* Reverted react-a11y-accessible-headings line
@IllusionMH IllusionMH added this to the 6.1.0-beta milestone Feb 19, 2019
apawast pushed a commit to lupine86/tslint-microsoft-contrib that referenced this issue Feb 26, 2019
…cy to 5.12.0) (microsoft#686)

* Deprecated now-duplicate rules from TSLint 5.12.0 (bumped devDependency to 5.12.0)

Fixes microsoft#684. Fixes microsoft#685.

* Added missing deprecation notices in README.md

* Update noUnnecessaryBindRule.ts

* Corrected changes in package-lock.json and metadata

* Fixed recommended ruleset and tslint warnings

* Removed breaking rule changes

* Fixed recommendation typos

* Updated metadata files

* Reverted react-a11y-accessible-headings line
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Domain: Tooling Repository tasks around improving source tooling. Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants