Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

no-http-string rule should support very large source files and string input #336

Closed
JoshuaKGoldberg opened this issue Jan 24, 2017 · 1 comment
Closed

no-http-string rule should support very large source files and string input #336

JoshuaKGoldberg opened this issue Jan 24, 2017 · 1 comment
Milestone
4.0.1

Comments

@JoshuaKGoldberg
Copy link

Fun little "the team's builds just started to hang for no reason" mayday after enabling no-http-string. Turns out we had a file with a serialized JSON string 1,466,450 characters long (don't ask). Hanging seems to start whenever a string is over about 200k characters.

We tested out using a simple indexOf instead of the regular expression and it stopped hanging.
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 24, 2017
Closed
@HamletDRC HamletDRC added this to the 3.0.1 milestone Feb 2, 2017
@HamletDRC
Copy link
Member

@JoshuaKGoldberg Thank you for taking the time to find and fix these issues!

@HamletDRC HamletDRC changed the title no-http-string hangs on ridiculously huge (JSON?) strings no-http-string rule should support very large source files and string input Mar 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.1
Development

No branches or pull requests
2 participants
@HamletDRC @JoshuaKGoldberg