Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typecheck before building app/main #1368

Merged
merged 2 commits into from
Mar 11, 2019
Merged

typecheck before building app/main #1368

merged 2 commits into from
Mar 11, 2019

Conversation

a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Mar 11, 2019 •
edited
Loading

Also fixes a missing constant reference

Added

  • [main] Typecheck during build process #1368

Fixed

  • [main] Fix missing constant reference #1368

tonyanziano
tonyanziano previously approved these changes Mar 11, 2019
View reviewed changes
@a-b-r-o-w-n a-b-r-o-w-n force-pushed the typecheck-before-build branch from c2a6383 to 29288c6 Compare March 11, 2019 22:19
@coveralls
Copy link

coveralls commented Mar 11, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2212

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.99%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/main/src/main.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 2210: 0.0%
Covered Lines: 4873
Relevant Lines: 8321
💛 - Coveralls

@a-b-r-o-w-n a-b-r-o-w-n merged commit 684a72c into microsoft:master Mar 11, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the typecheck-before-build branch March 11, 2019 22:29
@tonyanziano tonyanziano mentioned this pull request Mar 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinwilaby justinwilaby justinwilaby approved these changes

@tonyanziano tonyanziano tonyanziano left review comments

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a-b-r-o-w-n @coveralls @justinwilaby @tonyanziano