Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass username to webchat #1353

Merged
merged 4 commits into from
Mar 7, 2019
Merged

pass username to webchat #1353

merged 4 commits into from
Mar 7, 2019

Conversation

a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Mar 6, 2019 •
edited
Loading

fixes #1350

Fixed

  • [client] Pass along user name to webchat in PR #1353

tonyanziano
tonyanziano previously approved these changes Mar 6, 2019
View reviewed changes
@a-b-r-o-w-n a-b-r-o-w-n force-pushed the fix-missing-username branch from 02af3a7 to 964e658 Compare March 7, 2019 00:20
@coveralls
Copy link

coveralls commented Mar 7, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2166

  • 2 of 5 (40.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 54.956%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/ui/editor/emulator/parts/chat/chatContainer.ts 1 4 25.0%
Totals Coverage Status
Change from base Build 2165: -0.02%
Covered Lines: 4868
Relevant Lines: 8318
💛 - Coveralls

@cwhitten cwhitten merged commit eb85892 into microsoft:master Mar 7, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the fix-missing-username branch March 8, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinwilaby justinwilaby justinwilaby approved these changes

@tonyanziano tonyanziano tonyanziano left review comments

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

With BOT Emulator 4.3.0 no "name" is provided
5 participants
@a-b-r-o-w-n @coveralls @justinwilaby @tonyanziano @cwhitten