Consider 4xx and 5xx as failures #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jgogstad, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
| @@ -117,7 +117,7 @@ public void onEndRequest(ServletRequest req, ServletResponse res) { | |||
|
|
|||
| ApplicationInsightsHttpResponseWrapper response = ((ApplicationInsightsHttpResponseWrapper)res); | |||
| if (response != null) { | |||
| telemetry.setSuccess(response.getStatus() >= 200 && response.getStatus() < 300); | |||
| telemetry.setSuccess(response.getStatus() < 400); | |||
There was a problem hiding this comment.
Thanks for the contribution.
I see the .NET SDK also treat 401 as success
Please keep the same behavior so the SDKs are aligned. Thanks.
|
I will add another commit to identify 401 as success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirects shouldn't be considered failures, as reported in #281