Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web in release 2.2.1 doesn't relocate guava #784

Closed
petergphillips opened this issue Dec 10, 2018 · 1 comment · Fixed by #787
Closed

Web in release 2.2.1 doesn't relocate guava #784

petergphillips opened this issue Dec 10, 2018 · 1 comment · Fixed by #787
Assignees
Milestone

Comments

@petergphillips
Copy link

We have just tried upgrading to the latest version of application insights - 2.2.1.

The 2.2.0 web version had relocated the guava packages to com.microsoft.applicationinsights.core.dependencies.google.common, but this looks to have been removed in the 2.2.1 release.

Instead the applicationinsights-web-2.2.1.jar includes files under com.google.common without any relocation. This means that they conflict with guava itself and causes our application to no longer compile. The guava version used by insights seems to be very old and doesn't include com.google.common.util.concurrent.SimpleTimeLimiter.create, which was added in version 22 of guava, which causes us compilation problems as we are using those features.

Note that this only affects the -web version. The -core version correctly relocates the guava classes, but for some reason the 2.2.1 release of web no longer relocates.

@littleaj
Copy link
Contributor

Thank you for bringing this to our attention. We'll investigate the issue.

@littleaj littleaj added this to the 2.2.2 milestone Dec 12, 2018
@littleaj littleaj self-assigned this Dec 12, 2018
@littleaj littleaj added the Build label Dec 12, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants