fix(Twitter): Only support twitter.com urls

MichaelDeBoey · Oct 10, 2019 · 3c51a0e · 3c51a0e
1 parent a8e44f2
commit 3c51a0e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/Twitter.js b/src/Twitter.js
@@ -4,7 +4,7 @@ import fetch from 'node-fetch';
 export const shouldTransform = url => {
   const { host, pathname } = new URL(url);
 
-  return host.endsWith('twitter.com') && pathname.includes('/status/');
+  return host === 'twitter.com' && pathname.includes('/status/');
 };
 
 export const getHTML = url =>

diff --git a/src/__tests__/Twitter.js b/src/__tests__/Twitter.js
@@ -28,6 +28,14 @@ cases(
       url: 'https://not-a-twitter-url.com',
       valid: false,
     },
+    "non-Twitter url ending with 'twitter.com'": {
+      url: 'https://this-is-not-twitter.com',
+      valid: false,
+    },
+    "non-Twitter url ending with 'twitter.com' and having '/status/'": {
+      url: 'https://this-is-not-twitter.com/foobar/status/123',
+      valid: false,
+    },
     'profile url': {
       url: 'https://twitter.com/MichaelDeBoey93',
       valid: false,