Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix module mock #12

Merged
merged 2 commits into from
Nov 6, 2021

Conversation

PaperStrike
Copy link

@PaperStrike PaperStrike commented Nov 6, 2021

  • Use create-require polyfill to fix Module.createRequire for Node.js <= 12.2.0.
  • Use the mocked require to handle invocation of require created by createRequire.

eslint 7 - 8 fails for the promises, not for the mocks.

@codecov
Copy link

codecov bot commented Nov 6, 2021

Codecov Report

Merging #12 (d66b44c) into eslint-8 (7023001) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           eslint-8       #12   +/-   ##
==========================================
  Coverage    100.00%   100.00%           
==========================================
  Files             9         9           
  Lines           181       181           
==========================================
  Hits            181       181           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7023001...d66b44c. Read the comment docs.

@PaperStrike
Copy link
Author

cc @ljharb

@PaperStrike PaperStrike marked this pull request as draft November 6, 2021 07:17
@PaperStrike PaperStrike marked this pull request as ready for review November 6, 2021 07:53
@PaperStrike PaperStrike marked this pull request as draft November 6, 2021 11:56
@PaperStrike PaperStrike changed the title fix: use create-require polyfill fix: fix module mock Nov 6, 2021
@PaperStrike PaperStrike marked this pull request as ready for review November 6, 2021 12:10
@ljharb ljharb merged commit d66b44c into MichaelDeBoey:eslint-8 Nov 6, 2021
@PaperStrike PaperStrike deleted the eslint-8-module-mock branch November 7, 2021 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants