Improved Error and EDNS handling #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation to disable EDNS and to set the requested buffer size and DnsSec + Changing default unknown record handling to preserve the original data so that users can work with those records.
This was
linked to
issues
Mar 11, 2020
+ some other cleanup and fixes + decided to pull in a better implementation of StringBuilderObjectPool. There was one edge case breaking only in one very specific benchmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds EDNS options and proper handling of the response, including logging - see #61
Also:
I added a lot of new error handling and logging and changed the way the TCP fallback works a bit. It also has a bunch of new unit tests to test that behavior