Add support for building namespace.* without eval'ing nixpkgs
#459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerchunPak
commented
Jan 31, 2025
Comment on lines
+227
to
+231
| changed_attrs = {} | ||
| for system in self.systems: | ||
| changed_attrs[system] = set() | ||
| for package in self.only_packages: | ||
| changed_attrs[system].add(package) |
There was a problem hiding this comment.
I was unsure how to name a function that does this so I duplicated code instead
PerchunPak
force-pushed
the
build-namespace
branch
from
bfab973 to
8428a96
Compare
nixpkgs_review/nix/evalAttrs.nix
Outdated
| @@ -27,6 +27,12 @@ let | |||
| drvPath = null; | |||
| }) | |||
| ] | |||
| else if !lib.isDerivation pkg then | |||
| if builtins.typeOf pkg != "set" then | |||
| # if it is not a package, ignore it (it is probably something line overrideAttrs) | |||
There was a problem hiding this comment.
Suggested change
| # if it is not a package, ignore it (it is probably something line overrideAttrs) | |
| # if it is not a package, ignore it (it is probably something like overrideAttrs) |
?
Comment on lines
+227
to
+231
| changed_attrs = {} | ||
| for system in self.systems: | ||
| changed_attrs[system] = set() | ||
| for package in self.only_packages: | ||
| changed_attrs[system].add(package) |
nixpkgs_review/nix.py
Outdated
| @@ -251,6 +251,7 @@ def nix_eval( | |||
| "--nix-path", | |||
| nix_path, | |||
| "--json", | |||
| "--show-trace", | |||
There was a problem hiding this comment.
Maybe you forgot to remove this ?
There was a problem hiding this comment.
Not really, it does help a lot
There was a problem hiding this comment.
I'm not so sure about this... Anyway, let's not have it in this PR. Let's stick to the mentioned feature.
PerchunPak
force-pushed
the
build-namespace
branch
from
8428a96 to
6fe5864
Compare
|
It would be great to add a test. |
E.g. `nixpkgs-revew pr/rev --package vimPlugins` will build all packages that are in `vimPlugins` namespace`
PerchunPak
force-pushed
the
build-namespace
branch
from
6fe5864 to
568a10d
Compare
|
@GaetanLepage added tests, I hope correctly |
GaetanLepage
approved these changes
Feb 2, 2025
There was a problem hiding this comment.
LGTM, thanks @PerchunPak !
Have you been testing it on your side ?
|
Yes |
|
@mergify queue |
🛑 The pull request has been merged manuallyThe pull request has been merged manually at e0c47a9 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g.
nixpkgs-revew pr/rev --package vimPluginswill build all packages that are invimPluginsnamespace`Fixes #430
CC @GaetanLepage