-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support nixpkgs shallow clone and make use of github pull/<pr>/merge ref #426
Conversation
|
ace78ad
to
d2c0b50
Compare
The CI tests should be fixed in latest push. |
d6f4eeb
to
a218ae9
Compare
base_rev, pr_rev = fetch_refs( | ||
self.remote, | ||
pr["base"]["ref"], | ||
f"pull/{pr['number']}/merge", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact there is a race condition with this ref sometimes as github needs some time to compute it. But this is probably only relevant for CIs. So we should be unlikely to when humans run nixpkgs-review (except for @SuperSandro2000 maybe)
@mergify queue |
🛑 The pull request has been merged manuallyThe pull request has been merged manually at 055465e |
I've found one regression, if the PR is merged, |
Can we detect if |
We can use |
Fix #267