-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add support for multi-systems #419
Conversation
beb43b8
to
3f5e167
Compare
Changing report.json will need changes in nipkgs-update as well. |
From the code it looks like you handle local evaluation as well, no? |
3f5e167
to
4544694
Compare
No, the |
4544694
to
d8c9fb5
Compare
I have a sequential version working for |
|
d8c9fb5
to
471c058
Compare
471c058
to
f814a37
Compare
f814a37
to
c8b6826
Compare
7e3fd1e
to
bd89a3e
Compare
c287a18
to
0e18138
Compare
e9cf73c
to
05253cc
Compare
0468ea9
to
6549f1d
Compare
6549f1d
to
f007a08
Compare
f007a08
to
93732c7
Compare
This PR addresses #400 by allowing to evaluate a PR/revision for multiple systems at once.
You can now provide the
--systems
option with a list of systems to evaluate:--systems current
(default): legacy behavior--systems "x86_64-linux aarch64-darwin"
: evaluate for both intel linux and ARM darwin--systems all
: evaluate on all four main platformsProgress
report.json
,report.md
, stdout...)--eval ofborg
--eval local
(sequential)Support for-> Let's do this in a following PR. This one is already big enough.--eval local
(optionally parallel)Note
This is still a WIP.
The tool works fine when using ofborg eval but I have not yet adapted to local evaluation.The code is quite dirty for now and will require more polish
once everything will be working.Also, I am fully open to suggestions regarding the solution and coding style.
I am eager to receive some feedback !
Technical details
Every place where there was a list of attributes/packages/reports, we now need a
dict
mapping eachsystem
to this list.--system
option has been softly deprecated (warning + forwarding the value to--systems
) to avoid breaking the workflow of existing users.report.json
.cc @Mic92 @natsukium