avoid nix log warning
#335
Conversation
figsoda
commented
Jun 12, 2023
figsoda
commented
| @@ -67,7 +67,7 @@ def write_error_logs(attrs: List[Attr], directory: Path) -> None: | |||
| symlink_source.unlink() | |||
| symlink_source.symlink_to(attr.path) | |||
|
|
|||
| for path in [attr.drv_path, attr.path]: | |||
| for path in [f"{attr.drv_path}^*", attr.path]: | |||
There was a problem hiding this comment.
What happens if people now run the program on nixos 23.05?
There was a problem hiding this comment.
If that was an issue we could probably try both?
There was a problem hiding this comment.
works for me with nix 2.13.3 (nixVersions.nix_2_13 on nixpkgs unstable)
There was a problem hiding this comment.
Just to confirm you also had the nix-daemon running on this version?
There was a problem hiding this comment.
oops, I didn't, I will do a check with nix-daemon running nix 2.13
There was a problem hiding this comment.
I can confirm the nix log command still works after switching to nix 2.13 (including the daemon) on my machine
|
@mergify queue |
❌ Pull request must be rebased manuallyThe pull request can't be rebased without conflict and must be rebased manually |
|
@mergify rebase |
``` warning: The interpretation of store paths arguments ending in `.drv` recently changed. If this command is now failing try again with '...^*' ```
✅ Branch has been successfully rebased |
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 720dea6 |
