Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix reading github token from gh config #227

Merged
merged 2 commits into from
Nov 13, 2021
Merged

fix reading github token from gh config #227

merged 2 commits into from
Nov 13, 2021

Conversation

jyooru
Copy link
Contributor

@jyooru jyooru commented Nov 13, 2021

In ~/.config/gh/hosts.yaml I have:

github.com:
    user: jyooru
    oauth_token: gho_secrettokenhere
    git_protocol: ssh

nixpkgs-review is already reading this file, but the regex failed to detect my token. This pull request fixes this.

@Mic92 Mic92 merged commit d61898b into Mic92:master Nov 13, 2021
@jyooru jyooru deleted the fix/gh-token branch November 13, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyooru @Mic92