Fix "failed setting rlimit: invalid argument" on osx #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running on osx, the attempt to change the rlimit fails with "invalid argument". It appears that the value of rlimit.Max is `9223372036854775807`, and that trying to set to that value fails. More on this at golang/go#30401. We fix this by setting the value to the somewhat magic 24576 when on osx (darwin).
|
I opened #16 still need to figure why tests are broken now. |
|
fixed in #16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running on osx, the attempt to change the rlimit fails with "invalid argument".
It appears that the value of rlimit.Max is
9223372036854775807, and thattrying to set to that value fails. More on this at
golang/go#30401.
We fix this by setting the value to the somewhat magic 24576 when on osx (darwin).