Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve for OPNA #13

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Fix and improve for OPNA #13

merged 4 commits into from
Aug 9, 2024

Conversation

yosinda
Copy link
Contributor

@yosinda yosinda commented Aug 9, 2024

yosinda added 4 commits August 3, 2024 14:38
Change the trigger for starting a RAM WRITE/READ sequence from CS_n to WR_n/RD_n in jt08_adpcm_drvB.
Add the external input RD_n, which was omitted because it was not used until now.

RD_n is only used by JT08, so I won't add it to other wrappers.
- Fix IRQ_RESET not resetting EOS properly
- IRQ_RESET clear all flags including Timer-A/B
- IRQ_MASK will not update when IRQ_RESET is 1
- IRQ_MASK clear masked flags
A1 is saved when selecting a register (A0=0;WRITE).
When register writing (A0=1;WRITE), it is used to determine the destination register.

If A1=0 when selecting a register and A1=1 when writing, the data was written to the same register with A1=0 as when selected.
This case is generally a software bug.
But from a hardware point of view, it is correct not to write to a register unless it is the same A1 that was selected.

[Solution]
When writing to a register, write data only if A1 is the same as when selected.
In the "Sound Board 2" item of the OSD, set the location to connect Sound Board 2.

Expansion - Connect SB2 to the IO port of the expansion slot.
Onboard   - Connect SB2 to the IO port of the Onboard sound device.

NOTE:
Selecting "Expansion" will enable both the onboard SB1 and the expansion card's SB2.
Selecting "Onboard" will enable onboard SB2 and disable SB1.
@wwark
Copy link
Collaborator

wwark commented Aug 9, 2024

Thank you !!!!

@wwark wwark merged commit bc5f39f into MiSTer-devel:master Aug 9, 2024
theypsilon pushed a commit to MiSTer-unstable-nightlies/PC88_MiSTer that referenced this pull request Aug 9, 2024
@yosinda yosinda deleted the fix-jt08-1 branch August 10, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants