forked from rust-lang/libc
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use libc-test
for horizon OS
#8
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pthread_attr_t type can have priority and affinity values set. pthread_getpriority returns the priority of the current thread. These are needed to enable std thread support. std can't link directly with libctru so we go through pthread as an intermediate interface.
Add some extensions to pthread for armv6k-nintendo-3ds
Going through my old PRs and cleaning them up. This branch is pretty stale and I don't think it makes sense to upstream any of this, so just gonna close this, but it might be useful to dig up again if we ever run into ABI issues with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the interest of Meziu/rust-horizon#6 – this takes a first pass at using the libc test runner to compare ABIs and type sizes, but could be improved to include function signatures, constants, etc.
My plan is not to merge this as-is, but break out the functional changes in
libc
and deliver them separately. Maybe we want a "testing" branch for this to run the tests?Edit: a few instructions on how to actually run this, I forgot:
ctest2
to support the target:libc-test/.cargo/config.toml
:cargo 3ds test --test main
. Other tests have link errors currentlyLet me know if anything looks off here or you have questions, but I think this is a decent point for us to test some ABI mismatches and stuff.
@Meziu @AzureMarker