Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the rework of the option class. The main idea is to have one class per option, and that each class carries the URL construction and Symfony YAML configuration.
This is a work in progress. I think the simple options (height, width, rotate,...) are fine as I've done them, but there's still the imgproxy “meta options” (e.g. resize). I'd like these “meta options” to be based on the simple options to avoid duplicating code, but I haven't figured out how to do it properly yet.
If anyone has any ideas, I'd love to hear them.