Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean tspa io and some fixes #1095

Merged
merged 6 commits into from
May 19, 2022

Conversation

ldeniau
Copy link
Contributor

@ldeniau ldeniau commented Mar 29, 2022

The particle type detection based on relative error is extended to 1e-4.
Clean TPSA I/O (PR restored), backward compatible (default madxprint=false in a_scratch_size.f90, used only by TPSA low level I/O routines in [c]c_dabnew.f90).
mapdump add one more level to dump maps to all orders (was limited to 1st order before).

@ldeniau
Copy link
Contributor Author

ldeniau commented Mar 29, 2022

A comment about maxacceleration vs cavsareset in madx_ptc_module.f90. By default the code set cavreset to false independently of maxacceleration, while in some studies (MAD-NG energy patches for Linac4) I had to setup the value in a different way to get it working in MAD-X. The code is there but commented (for future review).

Copy link
Contributor

@rdemaria rdemaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me. Maybe Piotr could give a look...

@ldeniau
Copy link
Contributor Author

ldeniau commented Mar 30, 2022

Waiting for Piotr comment

@rdemaria rdemaria modified the milestones: 5.08, 5.07.02 Apr 4, 2022
@piotrskowronski
Copy link
Contributor

piotrskowronski commented May 18, 2022

This functionality was implemented for CTF3, RIP. I don't know any other machine that uses it.
It was never bulletproof and I know that at certain PTC version it become problematic. The issues are related to handling time true/false and totalpath true/false that this routine switches back and forth.

Therefore, I believe that it is wise to remove it and eventually re-design and re-implement it from scratch if some user requires it.

Please forgive me my delayed reaction, but since I left the group I keep ignoring the notifications from github.

@ldeniau ldeniau merged commit caf0f87 into MethodicalAcceleratorDesign:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants