Removed deprecated publication of legacy role assignments

History.md

@@ -4,6 +4,7 @@
 
 * BREAKING: Synchronous functions are now available only on client side
 * BREAKING: Migration functions for past versions are no longer available
+* Removed deprecated publication of legacy role assignments
 * UI Helpers now use `console.debug` for debugging messages
 * `RolesCollection` and `RoleAssignmentsCollection` can now be exported in addition to being accessed via `Meteor.roles` and `Meteor.roleAssignment`
 * Support for Meteor 3

package.js

@@ -32,8 +32,7 @@ Package.onUse(function (api) {
   api.addFiles('roles/roles_server.js', 'server')
   api.addFiles([
     'roles/client/debug.js',
-    'roles/client/uiHelpers.js',
-    'roles/client/subscriptions.js'
+    'roles/client/uiHelpers.js'
   ], 'client')
 })
 

roles/roles_client.js

@@ -1091,8 +1091,12 @@ Object.assign(Roles, {
   _checkScopeName: function (scopeName) {
     if (scopeName === null) return
 
-    if (!scopeName || typeof scopeName !== 'string' || scopeName.trim() !== scopeName) {
-      throw new Error('Invalid scope name \'' + scopeName + '\'.')
+    if (
+      !scopeName ||
+      typeof scopeName !== 'string' ||
+      scopeName.trim() !== scopeName
+    ) {
+      throw new Error(`Invalid scope name '${scopeName}'.`)
     }
   }
 })

roles/roles_server.js

@@ -15,23 +15,3 @@ for (const index of indexes) {
   indexFnAssignment(index)
 }
 indexFnRoles({ 'children._id': 1 })
-
-/*
- * Publish logged-in user's roles so client-side checks can work.
- *
- * Use a named publish function so clients can check `ready()` state.
- */
-Meteor.publish('_roles', function () {
-  const loggedInUserId = this.userId
-  const fields = { roles: 1 }
-
-  if (!loggedInUserId) {
-    this.ready()
-    return
-  }
-
-  return Meteor.users.find(
-    { _id: loggedInUserId },
-    { fields }
-  )
-})

roles/tests/clientAsync.js

@@ -12,7 +12,7 @@ import '../roles_common_async'
 chai.use(chaiAsPromised)
 
 const safeInsert = async (collection, data) => {
-  try {
+  return await collection.insertAsync(data).catch(e => console.error(e))
     await collection.insertAsync(data)
   } catch (e) {}
 }