Remove underscore + modernize code base #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @sakulstra |
Closed
|
ping @zimme |
Closed
3 tasks
|
@sebakerckhof OK, the plan is to merge the other two PRs and Meteor 1.6.1 branch, release and then update this and release as 1.0. |
|
@sebakerckhof Alright, v0.9.1 has been released. Time to get this moving again. |
|
Did the update, please check that I haven't done some mistakes in merger. @sebakerckhof Thanks! |
|
Will have to update lint rules to take care of new features. But I would like to wait on this till we decide in the organization about what rules to use. |
StorytellerCZ
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of: #247 with a broader scope to fully modernize the code base.
All tests are passing except in
direct.jsi had to disable some lines for which I think is a transpilation bug.Note that I did remove some BC stuff for really old versions of Meteor (pre 0.9)