Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDN Function.prototype.bind() polyfill throws error in ie8 #77

Closed
BenAHammond opened this issue Dec 14, 2014 · 4 comments
Closed

MDN Function.prototype.bind() polyfill throws error in ie8 #77

BenAHammond opened this issue Dec 14, 2014 · 4 comments

Comments

@BenAHammond
Copy link

The polyfill begins with this section:

if (!Function.prototype.bind) { // 3
Function.prototype.bind = function (oThis) { // 4
if (typeof this !== "function") { // 5
// closest thing possible to the ECMAScript 5 internal IsCallable function // 6
throw new TypeError("Function.prototype.bind - what is trying to be bound is not callable"); // 7
}

Which is firing because, in my debugger, "typeof this" == Object.

Help! I need your package and I need IE8 support!

@matb33
Copy link
Collaborator

matb33 commented Dec 14, 2014

I can't recall why the polyfill is there. Possibly leftover from legacy code. I'll look at this soon.

@BenAHammond
Copy link
Author

You're a lifesaver, thank you!

@matb33
Copy link
Collaborator

matb33 commented Dec 22, 2014

I removed the bind polyfill in 0.7.7

@matb33 matb33 closed this as completed Dec 22, 2014
@BenAHammond
Copy link
Author

Thank you!

On Mon, Dec 22, 2014 at 12:43 PM, Mathieu Bouchard <notifications@github.com

wrote:

I removed the bind polyfill in 0.7.7


Reply to this email directly or view it on GitHub
#77 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants