Fix: GenerateNonce(ECPubKey) wasn't random as expected #1228
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasDorier
force-pushed
the
fqirnqtn
branch
from
47b572f
to
b9bd973
Compare
NicolasDorier
force-pushed
the
fqirnqtn
branch
from
b9bd973
to
3e026f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because an empty
sessionIdwas passed instead of null, the nonce wouldn't be randomly generated, using a constant zero bytesessionIdleading to nonce reuse...Nonce reuse is as good as leaking private keys so this is a critical bug.
Reported by @angelonardone