Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/correct-install-docker-windows #106

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

retrevor
Copy link
Collaborator

@retrevor retrevor commented Feb 9, 2025

bugfix: Correction to docker-compose for Windows installations

  • add: updated default values of environment variables in docker-compose (in case the .env file is not read)
  • add: README documentation for known issues

bugfix(correct-install-docker-windows): add supporting images
@retrevor retrevor marked this pull request as ready for review February 9, 2025 22:28
Copy link
Member

@mahiarirani mahiarirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@JoaoSRaposo JoaoSRaposo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test OK:

  • Recreated dev env using new scripts

@mahiarirani
Copy link
Member

I haven't tested this on my system, but I don't think it's needed. The changes are very straight forward. It will only affect developer setup, so it's safe to merge for now.

@mahiarirani mahiarirani merged commit a83cd8d into stage Feb 13, 2025
2 checks passed
@mahiarirani mahiarirani deleted the bugfix/correct-install-docker-windows branch February 13, 2025 08:37
frozenbanana pushed a commit that referenced this pull request Feb 18, 2025
* - Correction to docker-compose for Windows installations.
- Added README for known issues

* Update README.md

bugfix(correct-install-docker-windows): add supporting images

* - add: formatting changes to README.md

---------

Co-authored-by: Take one <rontrevor@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants