Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export new modules #86

Merged
merged 3 commits into from
Feb 20, 2023
Merged

Export new modules #86

merged 3 commits into from
Feb 20, 2023

Conversation

gantunesr
Copy link
Member

This PR exports the new modules introduced in #74.

@gantunesr gantunesr requested a review from a team as a code owner February 20, 2023 19:14
Gudahtt
Gudahtt previously approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gantunesr gantunesr merged commit b3212b0 into main Feb 20, 2023
@gantunesr gantunesr deleted the export-new-types branch February 20, 2023 19:19
@Mrtenz
Copy link
Member

Mrtenz commented Feb 20, 2023

I wonder if we can add a check in CI for this. 🤔

@gantunesr
Copy link
Member Author

I think it's, but I guess there could be cases that we don't to expose a module and only use it internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gantunesr @Mrtenz @Gudahtt