Add Malformed Signatures #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaona
commented
Feb 10, 2024
| }, | ||
| message: { | ||
| name: 'Hello, Bob!', | ||
| extraData: 'This data is not typed!', |
There was a problem hiding this comment.
this is extra data not typed
seaona
commented
Feb 10, 2024
| */ | ||
| signEmptyDomain.onclick = async () => { | ||
| const msgParams = { | ||
| domain: {}, |
There was a problem hiding this comment.
this is the empty domain
seaona
commented
Feb 10, 2024
| { name: 'verifyingContract', type: 'address' }, | ||
| ], | ||
| OrderComponents: [ | ||
| { name: 'consideration', type: 'ConsiderationItem[+' }, |
There was a problem hiding this comment.
this is an invalid type definition
seaona
commented
Feb 10, 2024
| wallet: 'Hello, Bob!', | ||
| extraData: 'This data is not typed!', | ||
| }, | ||
| primaryType: 'Non-Existent', |
There was a problem hiding this comment.
this is an invalid primary type
seaona
commented
Feb 10, 2024
| }, | ||
| ], | ||
| }, | ||
| types: { |
There was a problem hiding this comment.
no primary type is defined
seaona
commented
Feb 11, 2024
| chainId: chainIdInt, | ||
| name: 'Seaport', | ||
| version: '1.5', | ||
| verifyingContract: 1, |
There was a problem hiding this comment.
this is an invalid value (expected address)
darkwing
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds different malformed typed signatures.
Note, at the moment, clicking most of them results in breaking MetaMask
This uncovers the following bugs on Extension:
On Mobile, the wallet does not break on any of these cases, bc there's little support to validations overall, so they need to be revised entirely.
Screenshots
test-dapp-malformed-signatures.mp4
test-dapp-malformed-signatues-mobile.mp4