Skip to content

logout() fucntion added and isSessionIdExists() removed. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

logout() fucntion added and isSessionIdExists() removed. #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee3806c
logout() fucntion added and isSessionIdExists() modified
grvgoel81 Sep 23, 2024
a953664
isSessionIdExists() method removed
grvgoel81 Sep 24, 2024
c02caeb
saveSessionId methos added.
grvgoel81 Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions Sources/SingleFactorAuth/SingleFactorAuth.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,6 @@ public class SingleFactorAuth {
let publicAddress = data["publicAddress"] as? String else { throw SessionManagerError.decodingError }
return .init(privateKey: privKey, publicAddress: publicAddress)
}

public func isSessionIdExists() -> Bool {
if (sessionManager.getSessionID() != nil) && !(sessionManager.getSessionID()!.isEmpty) {
return true
}
return false
}

public func getTorusKey(loginParams: LoginParams) async throws -> TorusKey {
var retrieveSharesResponse: TorusKey
Expand Down Expand Up @@ -90,7 +83,13 @@ public class SingleFactorAuth {
let privateKey = torusKey.finalKeyData.privKey

let sfaKey = SFAKey(privateKey: privateKey, publicAddress: publicAddress)
_ = try await sessionManager.createSession(data: sfaKey)
let sessionId = try await sessionManager.createSession(data: sfaKey)
sessionManager.saveSessionId(sessionId)
return sfaKey
}

public func logout() async throws -> Bool {
let logoutResult = try await sessionManager.invalidateSession()
return logoutResult
}
}
9 changes: 9 additions & 0 deletions Tests/SingleFactorAuthTests/SapphireMainnetTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,13 @@ final class SapphireMainnetTests: XCTestCase {
XCTAssertEqual(requiredPrivateKey, torusKey.getPrivateKey())
XCTAssertEqual("0xA92E2C756B5b2abABc127907b02D4707dc085612", torusKey.getPublicAddress())
}

func testLogout() async throws {
let idToken = try generateIdToken(email: TORUS_TEST_EMAIL)
let loginParams = LoginParams(verifier: TEST_VERIFIER, verifierId: TORUS_TEST_EMAIL, idToken: idToken)
let _ = try await singleFactoreAuth.connect(loginParams: loginParams)

let result = try await singleFactoreAuth.logout()
XCTAssertEqual(result, true)
}
}
Loading