Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: experimental deeplink protocoll #990

Merged
merged 3 commits into from
Aug 20, 2024
Merged

feat: experimental deeplink protocoll #990

merged 3 commits into from
Aug 20, 2024

Conversation

abretonc7s
Copy link
Collaborator

@abretonc7s abretonc7s commented Aug 20, 2024

  • Fixes on resume for wallet in order to use the new join channel flow

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.46%. Comparing base (e704883) to head (691bc92).
Report is 1 commits behind head on main.

Files Patch % Lines
...kages/sdk/src/provider/initializeMobileProvider.ts 0.00% 6 Missing ⚠️
...services/SocketService/ConnectionManager/resume.ts 83.33% 4 Missing ⚠️
...rvice/ConnectionManager/handleJoinChannelResult.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
- Coverage   80.72%   80.46%   -0.27%     
==========================================
  Files         180      180              
  Lines        4037     4054      +17     
  Branches     1007     1008       +1     
==========================================
+ Hits         3259     3262       +3     
- Misses        778      792      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abretonc7s abretonc7s marked this pull request as ready for review August 20, 2024 15:14
@abretonc7s abretonc7s requested a review from a team as a code owner August 20, 2024 15:14
@abretonc7s abretonc7s enabled auto-merge (squash) August 20, 2024 15:19
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abretonc7s abretonc7s merged commit 935b2ac into main Aug 20, 2024
28 checks passed
@abretonc7s abretonc7s deleted the experimental branch August 20, 2024 15:20
Copy link

@abretonc7s abretonc7s mentioned this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants