Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto activate deeplink protocol when wallet supports it #1056

Merged
merged 6 commits into from
Sep 30, 2024

Conversation

abretonc7s
Copy link
Collaborator

@abretonc7s abretonc7s commented Sep 28, 2024

Explanation

  • Detect deeplink protocol from the wallet directly.
  • Remove option from connection properties

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@abretonc7s abretonc7s requested a review from a team as a code owner September 28, 2024 05:11
@abretonc7s abretonc7s changed the title feat: auto detect deeplink protocol support on rpc feat: auto activate deeplink protocol when wallet supports it Sep 28, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 78.34%. Comparing base (f436d08) to head (628a2a9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ication/MessageHandlers/handleWalletInitMessage.ts 0.00% 6 Missing ⚠️
...sdk-communication-layer/src/RemoteCommunication.ts 0.00% 4 Missing ⚠️
...ices/RemoteCommunicationPostMessageStream/write.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1056      +/-   ##
==========================================
- Coverage   78.55%   78.34%   -0.22%     
==========================================
  Files         179      179              
  Lines        4140     4146       +6     
  Branches     1021     1022       +1     
==========================================
- Hits         3252     3248       -4     
- Misses        888      898      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copy link
Contributor

@elefantel elefantel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abretonc7s abretonc7s merged commit 570fba2 into main Sep 30, 2024
35 of 37 checks passed
@abretonc7s abretonc7s deleted the feat/deeplinkprotocolrpc branch September 30, 2024 08:44
@abretonc7s abretonc7s mentioned this pull request Oct 3, 2024
christopherferreira9 pushed a commit that referenced this pull request Oct 18, 2024
* feat: extra logs on socket server for analytics cache

* fix: connect with potentially receiving response from different method

* feat: auto detect deeplink protocol support

* feat: remove unnecessary option - let wallet send information

* fix: unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants