-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: event alignment with async protocol #1054
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1054 +/- ##
==========================================
- Coverage 78.34% 78.16% -0.19%
==========================================
Files 179 179
Lines 4146 4153 +7
Branches 1022 1020 -2
==========================================
- Hits 3248 3246 -2
- Misses 898 907 +9 ☔ View full report in Codecov by Sentry. |
* feat: extra logs on socket server for analytics cache * fix: connect with potentially receiving response from different method * feat: auto detect deeplink protocol support * feat: event handling with async protocol * fix: unit tests
Explanation
This PR attempt to start cleaning up event emission while using async key exchange.
References
Checklist