Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: missing extension analytics event for personal_sign #1048

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

abretonc7s
Copy link
Collaborator

@abretonc7s abretonc7s commented Sep 25, 2024

Explanation

add missing event on extension.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@abretonc7s abretonc7s requested a review from a team as a code owner September 25, 2024 14:17
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.03%. Comparing base (19cb78c) to head (2e7ada4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1048   +/-   ##
=======================================
  Coverage   79.03%   79.03%           
=======================================
  Files         179      179           
  Lines        4126     4126           
  Branches     1019     1019           
=======================================
  Hits         3261     3261           
  Misses        865      865           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copy link
Contributor

@elefantel elefantel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abretonc7s abretonc7s merged commit df9a2bf into main Sep 25, 2024
37 checks passed
@abretonc7s abretonc7s deleted the missingextensionevent branch September 25, 2024 14:44
@abretonc7s abretonc7s mentioned this pull request Oct 3, 2024
christopherferreira9 pushed a commit that referenced this pull request Oct 18, 2024
feat: missing extension event for personal_sign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants