Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: connectwith working with async key exchange #1004

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Conversation

abretonc7s
Copy link
Collaborator

Explanation

Support connectWith via async key exchange.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@abretonc7s abretonc7s self-assigned this Aug 28, 2024
@abretonc7s abretonc7s requested a review from a team as a code owner August 28, 2024 14:12
omridan159
omridan159 previously approved these changes Aug 28, 2024
@abretonc7s abretonc7s changed the title feat: connectwith working with connection feat: connectwith working with async key exchange Aug 28, 2024
andreahaku
andreahaku previously approved these changes Aug 28, 2024
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abretonc7s abretonc7s dismissed stale reviews from andreahaku and omridan159 via d5a9628 August 29, 2024 02:27
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.57%. Comparing base (ba2dd08) to head (7d42e7b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...kages/sdk/src/provider/initializeMobileProvider.ts 0.00% 3 Missing ⚠️
packages/sdk/src/Platform/MetaMaskInstaller.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1004   +/-   ##
=======================================
  Coverage   80.57%   80.57%           
=======================================
  Files         177      177           
  Lines        3990     4001   +11     
  Branches      990      993    +3     
=======================================
+ Hits         3215     3224    +9     
- Misses        775      777    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copy link
Collaborator

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (re-approving)

@abretonc7s abretonc7s merged commit ec20994 into main Aug 29, 2024
36 of 37 checks passed
@abretonc7s abretonc7s deleted the deeplinkrpc branch August 29, 2024 10:29
@abretonc7s abretonc7s mentioned this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: connectAndSign and connectWithnot working properly
4 participants