Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migration 43 stringify to type of #9982

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

tommasini
Copy link
Contributor

Description

typeof rather than stringily here because this would result in a great deal of data in our error message. This is problematic for two reasons: it means that each unique network configuration gets interpreted as a unique error by Sentry, no grouping. And it potentially exposes private information.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Jun 13, 2024
@tommasini tommasini requested a review from a team as a code owner June 13, 2024 17:14
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini merged commit 57a7545 into release/7.24.1 Jun 13, 2024
30 checks passed
@tommasini tommasini deleted the fix/migration-43 branch June 13, 2024 17:29
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 13, 2024
@metamaskbot metamaskbot added the release-7.24.3 Issue or pull request that will be included in release 7.24.3 label Jun 19, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.24.3 on PR, as PR was added to branch 7.24.3 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.24.3 Issue or pull request that will be included in release 7.24.3 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants